fix(calendar): stop writing blank participant names and empty descriptions - #748
Open
lucletoffe wants to merge 1 commit into
Open
fix(calendar): stop writing blank participant names and empty descriptions#748lucletoffe wants to merge 1 commit into
lucletoffe wants to merge 1 commit into
Conversation
…tions Both reach the recipient of an invitation. A participant sent with `name: ""` is serialized as a bare `CN=`, so the invitation e-mail shows a dangling "- Organizer" and lists guests with nothing before their address; omitting the name lets clients fall back to the address. An event created with an empty description writes `DESCRIPTION:` with nothing after it, which renders as a "Description" heading over blank space — the empty string is still sent when editing an existing event, since that is how a description gets cleared. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YS9FfeGXhm9HBwbRyvJ1db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When creating a calendar event, the composer writes
name: ""for every participant that has no display name, and an emptydescriptionproperty. Both end up serialized by the JMAP server into iCalendar as empty parameters/properties (CN=,DESCRIPTION:), which then leak into everything downstream:CN=too — this is client-inflicted, not server-specific).DESCRIPTIONproduces a "Description" section heading over nothing in invitation mails.ORGANIZER;CN=with an empty CN parameter defeats the RFC-style attendee/organizer merge in some iCalendar→JSCalendar converters, so the organizer is duplicated as a phantom third participant with no name and no email (renders as "Unknown" in clients).Fix
Omit
namewhen there is no display name, and omitdescriptionwhen it is empty, instead of sending empty strings. Properties that are absent cannot be mis-serialized.Typechecked and running in a private deployment.