Skip to content

Fix plugin crypto API method name mismatch in runtime bridge - #747

Draft
rathlinus with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-comments-in-review-thread-again
Draft

Fix plugin crypto API method name mismatch in runtime bridge#747
rathlinus with Copilot wants to merge 1 commit into
mainfrom
copilot/fix-comments-in-review-thread-again

Conversation

Copilot AI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR addresses the review-thread issue where the plugin runtime called a non-existent crypto host API method. The runtime now uses the method name expected by the protocol/host dispatch so plugin crypto calls are routed correctly.

  • Runtime API alignment

    • Updated the plugin sandbox runtime host call from crypto.fetchPublicKeys to crypto.getPublicKeys to match the allowed/implemented host API surface.
  • Behavioral impact

    • Prevents valid plugin calls from being rejected as unknown methods due to naming mismatch.
    • Restores compatibility between runtime bridge calls and host-side method dispatch.
// before
callApi('crypto.fetchPublicKeys', args)

// after
callApi('crypto.getPublicKeys', args)

Copilot AI lite review requested due to automatic review settings August 5, 2026 22:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI changed the title [WIP] Fix code based on review comments Fix plugin crypto API method name mismatch in runtime bridge Aug 5, 2026
Copilot AI requested a review from rathlinus August 5, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants