Draft
Add regression test for dir attribute preservation in email sanitizer#745
dir attribute preservation in email sanitizer#745Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot
AI
changed the title
[WIP] Fix code as per review comment in PR 713
Add regression test for Aug 5, 2026
dir attribute preservation in email sanitizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the PR review comment requesting coverage for the newly allowed
dirattribute inEMAIL_SANITIZE_CONFIG. The change is scoped to a focused regression test to prevent future sanitizer regressions affecting RTL content.What changed
sanitizeEmailHtmlasserting thatdiris preserved on sanitized elements (example:<p dir="rtl">...</p>).Why this matters
Example assertion