Skip to content

chore(deps): bump the sdk version to 1.7.0 - #347

Merged
mcncl merged 1 commit into
mainfrom
chore/bump_gosdk_1.7.0
Jul 28, 2026
Merged

chore(deps): bump the sdk version to 1.7.0#347
mcncl merged 1 commit into
mainfrom
chore/bump_gosdk_1.7.0

Conversation

@mcncl

@mcncl mcncl commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Bumps the go-sdk version to v1.7.0 and add fix for Capabilities with new spec.

Copilot AI review requested due to automatic review settings July 28, 2026 23:36
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​modelcontextprotocol/​go-sdk@​v1.7.0-pre.3 ⏵ v1.7.073 +110010010060

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Buildkite MCP server to use github.com/modelcontextprotocol/go-sdk v1.7.0 and adjusts server initialization to avoid advertising the deprecated logging capability by default under the updated MCP spec behavior.

Changes:

  • Bump github.com/modelcontextprotocol/go-sdk from v1.7.0-pre.3 to v1.7.0.
  • Initialize mcp.ServerOptions.Capabilities with a non-nil empty mcp.ServerCapabilities{} to prevent default advertising of the deprecated logging capability.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
pkg/server/mcp.go Sets an explicit (empty) server capabilities object to prevent deprecated logging capability from being advertised by default.
go.mod Bumps github.com/modelcontextprotocol/go-sdk dependency to v1.7.0.
go.sum Updates checksums for the go-sdk v1.7.0 upgrade.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wolfeidau wolfeidau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE 👍🏻

@buildsworth-bk-app buildsworth-bk-app Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK option matches its documented capability-inference behavior; I left one non-blocking coverage suggestion. This changes the server's advertised MCP protocol contract, so this is a comment-only review from me.

Want to dig deeper?

Paste this into your agent to explore the findings from this review's Buildkite build:

Download the buildsworth logs from build 9366, then answer my questions about the findings.

Install the reading-buildsworth-logs skill to run this.

About buildsworth

Model: gpt-5.6-sol with xhigh thinking.

How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.

Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):

  • L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
  • L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
  • L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.

Comment thread pkg/server/mcp.go
// deprecated (as of MCP 2026-07-28) logging capability by default.
// Tool, prompt, and resource capabilities are still inferred as they
// are registered.
Capabilities: &mcp.ServerCapabilities{},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: An over-the-wire test of the advertised capability set would protect the behavior this change is fixing; the existing server tests still pass if this option is removed. ClientSession.InitializeResult().Capabilities can assert that Logging is nil while tools, prompts, and resources remain inferred.

@mcncl
mcncl merged commit fad98e6 into main Jul 28, 2026
5 checks passed
@mcncl
mcncl deleted the chore/bump_gosdk_1.7.0 branch July 28, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants