Add nested GITHUB_TOKEN permissions oracle - #179
Closed
lox wants to merge 2 commits into
Closed
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019ff5bd-ce7b-7433-8540-93abf1af04c0 Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019ff5bd-ce7b-7433-8540-93abf1af04c0 Co-authored-by: Lachlan Donald <lachlan@buildkite.com>
There was a problem hiding this comment.
No findings from this pass. This change exercises GITHUB_TOKEN issuance and permission propagation across nested reusable workflows, so it needs a human review before merge.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 14920, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Clarify how GitHub scopes and issues
GITHUB_TOKENvalues for jobs expanded through nested reusable workflows, as discussed in #160.What
Add a manually dispatched oracle with two nested reusable-workflow chains. The caller grants each chain a different permission, and a final job compares SHA-256 token fingerprints without exposing either token. GitHub's job setup logs show the effective permissions for each leaf job.