IVS-866 - Ability to navigate to end-user reports

[rw-bsi]

• support both request_id (as-is) and model_id
• allow is_staff users to render all reports

[Ghesselink]

Nice :-)

[Ghesselink]

The code only creates priv_id when the id starts with r or m, so any other id (like t42 or whatever) reaches 'if not priv_id). This doesn't exist or can't convert to an integer and crashes with a 500 error. Adding else: return HttpResponseNotFound() and try/except makes those ids get 404 instead.

Suggested change

	if id.startswith("r"):
	priv_id = ValidationRequest.to_private_id(id)
	elif id.startswith("m"):
	model_id = Model.to_private_id(id)
	priv_id = (
	ValidationRequest.objects.filter(model_id=model_id)
	.values_list("id", flat=True)
	.first()
	)
	if not priv_id:
	return HttpResponseNotFound()
	try:
	if id.startswith("r"):
	priv_id = ValidationRequest.to_private_id(id)
	elif id.startswith("m"):
	model_id = Model.to_private_id(id)
	priv_id = (
	ValidationRequest.objects.filter(model_id=model_id)
	.values_list("id", flat=True)
	.first()
	)
	else:
	return HttpResponseNotFound()
	except ValueError:
	return HttpResponseNotFound()
	if not priv_id:
	return HttpResponseNotFound()