Repository navigation
Conversation
--execution-result was passed as a string and the source lists were written by a separate action with string paths, so neither was rewritten under --experimental_output_paths=strip: every pmd_test and any target with generated sources failed. Pass the result as a File, write the source lists as param files of the PMD action, and declare supports-path-mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
--experimental_output_paths=strip, everypmd_testand any target with generated sources failed:--execution-resultwas a string path and the source lists were written with string paths, so Bazel couldn't map them.--execution-resultas a File.srcs/srcs_ignorelists as param files of the PMD action, so their contents are mapped too (run_pmd.shnow reads them from--file-list=/--exclude-file-list=).supports-path-mappingon the PMD action.Analysis tests updated for the param-file lists. Integration tests pass with and without path mapping.
This also removes the generated
srcs_*.txtfiles, which supersedes #121.