Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 933 933
=========================================
Hits 933 933 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR targets linter/vet warnings in the semver dependency resolver by adjusting formatting in debug logging and tweaking a generic NewResolver instantiation in tests.
Changes:
- Updated several
debug(...)format verbs inResolver.resolve()from%sto%vto satisfy printf-style checks for non-string arguments. - Updated the test to instantiate
NewResolverwith fewer explicit type arguments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| resolver.go | Fixes printf-style format verb mismatches in debug logging within the resolver backtracking flow. |
| resolver_test.go | Changes generic NewResolver instantiation used by the resolver unit test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| i170 := rel("I", "1.7.0", deps()) | ||
| i180 := rel("I", "1.8.0", deps()) | ||
| arch := NewResolver[*customRel, *customDep]() | ||
| arch := NewResolver[*customRel]() |
There was a problem hiding this comment.
NewResolver is declared with two type parameters (NewResolver[R Release[D], D Dependency]()), so calling it with only one explicit type argument is likely to fail to compile. Either provide both type arguments here (as before), or change NewResolver's signature to a single type parameter if the dependency type is meant to be inferred.
| arch := NewResolver[*customRel]() | |
| arch := NewResolver[*customRel, *customDep]() |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.