Skip to content

Fixed linter warnings - #29

Merged
cmaglie merged 2 commits into
masterfrom
linter
Apr 14, 2026
Merged

cmaglie merged 2 commits into
masterfrom
linter

Conversation

@cmaglie

@cmaglie cmaglie commented Apr 14, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Apr 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a17ccc4) to head (5961682).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          933       933           
=========================================
  Hits           933       933           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR targets linter/vet warnings in the semver dependency resolver by adjusting formatting in debug logging and tweaking a generic NewResolver instantiation in tests.

Changes:

  • Updated several debug(...) format verbs in Resolver.resolve() from %s to %v to satisfy printf-style checks for non-string arguments.
  • Updated the test to instantiate NewResolver with fewer explicit type arguments.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
resolver.go Fixes printf-style format verb mismatches in debug logging within the resolver backtracking flow.
resolver_test.go Changes generic NewResolver instantiation used by the resolver unit test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread resolver_test.go
i170 := rel("I", "1.7.0", deps())
i180 := rel("I", "1.8.0", deps())
arch := NewResolver[*customRel, *customDep]()
arch := NewResolver[*customRel]()

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NewResolver is declared with two type parameters (NewResolver[R Release[D], D Dependency]()), so calling it with only one explicit type argument is likely to fail to compile. Either provide both type arguments here (as before), or change NewResolver's signature to a single type parameter if the dependency type is meant to be inferred.

Suggested change
arch := NewResolver[*customRel]()
arch := NewResolver[*customRel, *customDep]()

Copilot uses AI. Check for mistakes.
Comment thread resolver.go Resolved
Comment thread resolver.go Resolved
Comment thread resolver.go Resolved
@per1234 per1234 added the bug Something isn't working label Apr 14, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cmaglie
cmaglie merged commit 7fb000f into master Apr 14, 2026
5 checks passed
@cmaglie
cmaglie deleted the linter branch April 14, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants