Skip to content

[zstd] Build zstd library #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lbcjbb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[zstd] Build zstd library #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ bazel_dep(name = "rules_proto", version = "7.1.0")
bazel_dep(name = "rules_pkg", version = "1.1.0")
bazel_dep(name = "rules_oci", version = "2.2.6")

# Ensure this version of the libzstd is supported by github.com/valyala/gozstd.
bazel_dep(name = "zstd", version = "1.5.7.bcr.1")

# TODO: Remove `aspect_bazel_lib` as a direct dep once higher version of `rules_oci` is available.
# See also: https://github.com/bazel-contrib/rules_oci/pull/842
bazel_dep(name = "aspect_bazel_lib", version = "2.21.2")
Expand All @@ -20,6 +23,7 @@ oci.pull(
tag = "nonroot-amd64",
)
use_repo(oci, "cgo_amd64_base")

oci.pull(
name = "cgo_arm64_base",
image = "gcr.io/distroless/base-nossl-debian12",
Expand Down Expand Up @@ -136,3 +140,5 @@ use_repo(
"org_golang_x_oauth2",
"org_golang_x_sync",
)

inject_repo(go_deps, "zstd")
29 changes: 2 additions & 27 deletions patches/gozstd.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,33 +3,8 @@ new file mode 100644
index 0000000..2dd6245
--- /dev/null
+++ b/BUILD.bazel
@@ -0,0 +1,76 @@
@@ -0,0 +1,51 @@
+load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
+
+cc_library(
+ name = "libzstd",
+ srcs = select({
+ "@io_bazel_rules_go//go/platform:android_amd64": ["libzstd_linux_amd64.a"],
+ "@io_bazel_rules_go//go/platform:android_arm": ["libzstd_linux_arm.a"],
+ "@io_bazel_rules_go//go/platform:android_arm64": ["libzstd_linux_arm64.a"],
+ "@io_bazel_rules_go//go/platform:darwin_amd64": ["libzstd_darwin_amd64.a"],
+ "@io_bazel_rules_go//go/platform:darwin_arm64": ["libzstd_darwin_arm64.a"],
+ "@io_bazel_rules_go//go/platform:freebsd_amd64": ["libzstd_freebsd_amd64.a"],
+ "@io_bazel_rules_go//go/platform:ios_amd64": ["libzstd_darwin_amd64.a"],
+ "@io_bazel_rules_go//go/platform:ios_arm64": ["libzstd_darwin_arm64.a"],
+ "@io_bazel_rules_go//go/platform:linux_amd64": ["libzstd_linux_amd64.a"],
+ "@io_bazel_rules_go//go/platform:linux_arm": ["libzstd_linux_arm.a"],
+ "@io_bazel_rules_go//go/platform:linux_arm64": ["libzstd_linux_arm64.a"],
+ "@io_bazel_rules_go//go/platform:windows_amd64": ["libzstd_windows_amd64.a"],
+ "//conditions:default": ["UNSUPPORTED_PLATFORM"],
+ }),
+ hdrs = [
+ "zdict.h",
+ "zstd.h",
+ "zstd_errors.h",
+ ],
+)
+
+go_library(
+ name = "gozstd",
Expand All @@ -48,7 +23,7 @@ index 0000000..2dd6245
+ "stream.go",
+ "writer.go",
+ ],
+ cdeps = [":libzstd"],
+ cdeps = ["@zstd"],
+ cgo = True,
+ copts = ["-O3"],
+ importpath = "github.com/valyala/gozstd",
Expand Down