Repository navigation
fix(cmd): start blob-store age sweeper in the all-in-one binary - #269
Merged
Merged
Conversation
…blockchain#267) The sweeper was wired only into cmd/block-processor, so all-in-one deployments never age-swept file:// subtree blobs. A production store grew to 5.5M files in one directory, filled ext4's htree index and failed every write with ENOSPC at 19% disk usage, stalling SEEN_ON_NETWORK.
👋 Thanks, @mboyd1!This pull request comes from a fork. For security, our CI runs in a restricted mode.
Thanks for contributing to bsv-blockchain/merkle-service! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
cmd/merkle-service/main.gonow callsstore.StartAgeSweeperFromConfig(and defers its stop), mirroringcmd/block-processor/main.go.Why It Was Necessary
large_dir), and every blob write failed with ENOSPC at 19% disk usage. That stalled SEEN_ON_NETWORK for weeks.Testing Performed
CGO_ENABLED=0 go build ./cmd/merkle-service,go vet ./cmd/merkle-service/,go test ./internal/store/ -run Sweep.sweepIntervalSec/sweepMaxAgeSecis 0, so test and ephemeral setups are unaffected.Impact / Risk
sweep()before the ticker). On the 5.5M-file store that would be a one-time multi-minute directory walk.Notifications