Added tags to test compatibility with the new SmartThings app - #126
Open
mssaleh wants to merge 5 commits into
Open
Added tags to test compatibility with the new SmartThings app#126mssaleh wants to merge 5 commits into
mssaleh wants to merge 5 commits into
Conversation
Collaborator
|
Hi. Thanks for the contribution. You don't actually need to submit a pull request to do this kind of testing. Just change the code in your local copy of the DTH in your IDE, and try it out on your mobile device with the new ST app. Personally I am not using the new mobile app and don't plan to until official support has been announced for third party DTHs. It wouldn't make sense to commit this pull request until it's been thoroughly tested. Please feel to share the pull request modifications with folks on the ST community forums in order to get more people testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if these tags are enough, but I'd like to test them with the new app.