Support Keenhome.io variant's pressure data - #119
Open
Gr1mR3aver wants to merge 2 commits into
Open
Conversation
Updated read attribute handling pressure calcs to additionally support attrId "0020", in order to make this handler suitable for the Keenhome.io variant of this device.
Collaborator
|
I looked over the code changes and it looks fine to me - Thanks for this! I had no idea that any Xiaomi devices had been re-purposed for use in a different custom-hub solution as Keen Home is doing. They must be making good profit charging $40 US for a sensor that Xiaomi sells for $15! Since I don't own one myself - can you confirm that all other functions (temperature / humidity / battery) of the Keenhome.io sensor variant work correctly with the Aqara Temp-Humidity Sensor SmartThings device handler? |
Author
|
Battery reporting doesn't seem to work on these units, since I see zero battery "catchall:" messages in the debug log. temp, humidity and pressure are all working. I *have* seen some odd "network issue" messages whenever I go to the "Recents" tab in the device UI in the app, but it seems to be an innocuous error since I'm seeing continuous temp/humidity/pressure events.
One point to note: I am running a v1 hub, thought I don't think that will make a difference.
Thanks,
Paul
…________________________________
From: Keith G <notifications@github.com>
Sent: Tuesday, July 17, 2018 4:01 PM
To: bspranger/Xiaomi
Cc: Gr1mR3aver; Author
Subject: Re: [bspranger/Xiaomi] Support Keenhome.io variant's pressure data (#119)
I looked over the code changes and it looks fine to me - Thanks for this!
I had no idea that any Xiaomi devices had been re-purposed for use in a different custom-hub solution as Keen Home is doing. They must be making good profit charging $40 US for a sensor that Xiaomi sells for $15!
Since I don't own one myself - can you confirm that all other functions (temperature / humidity / battery) of the Keenhome.io sensor variant work correctly with the Aqara Temp-Humidity Sensor SmartThings device handler?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbspranger%2FXiaomi%2Fpull%2F119%23issuecomment-405726410&data=02%7C01%7C%7C293c90c8b50745a7aba008d5ec2866ee%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636674580615629775&sdata=dfB5CKVOzsFlYb0f%2B3j%2FXPd9VnXhU%2F%2FGcPMK4gV9Wow%3D&reserved=0>, or mute the thread<https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWGnYjR-9FppJ-k-mXJOkjmiGz_Slm3Zks5uHlCLgaJpZM4VOLQu&data=02%7C01%7C%7C293c90c8b50745a7aba008d5ec2866ee%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636674580615629775&sdata=8vXPJOgT8odoB9pt7n6%2BevkBCl%2BsE8E3rAbn4%2BdlTbQ%3D&reserved=0>.
|
Ingramz
reviewed
Jul 18, 2018
fixed conditional to use || instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated read attribute handling pressure calcs to additionally support attrId "0020", in order to make this handler suitable for the Keenhome.io variant of this device.