Siunitx version 3#2784
Conversation
|
I may need some help debugging why the tests are failing. For TexLive 2021, I'm not sure why |
|
@teepeemm first thought before looking at any of your changes -- try syncing with the upstream master branch before continuing: We have CI passing now, so getting to the latest state will make this easier to review by everyone. |
note that xml has minimal diff. only change in html is `\SI{1e-#}{}` went from `<msup><mi>10</mi><mi>-#</mi></msup>` to `<msup><mn>10</mn><mrow><mo>−</mo><mn>#</mn></mrow></msup>`
also a few bug fixes
also, better handling of 123.
note that the binding didn't change
note that si.xml does not change
specifically, options that are valid in v2 but give different results
|
Catching up to upstream/master did occur to me, and I think I did that (somewhere around the 6afbc9f commit). It seems like I was failing because of the class I've completely disabled the siV3 test, so we'll need to look into why that wasn't working. I'm not seeing I'm not sure why 2021 is still failing. I'm not seeing what would cause |
|
Congrats on passing CI! I will take some time to review next week, apologies for being a little short on time. |
|
I figured out why siV3 was having trouble, and left a comment in I'm still not sure why |
|
I'm unable to get the |
I've gone through the documentation for siunitx version 3, and tested out as many options as I could. As I mentioned, I tried to allow v2 or v3 syntax without throwing any warnings (in contrast to the tex version). There are a few instances where something is valid in both versions but gives different results; these have gone into separate (and short) test files. There is also a test file for v3 options that are only allowed to change in the preamble (or even only while loading the package). Note that implementing the v2 tests does mean that we now have a texlive_max option that we'll want to use sparingly.
There's many commits because I was trying to keep diffs to a minimum, except where necessary. I think the commit messages should indicate where that happened and why.
This fixes #1734