Skip to content

allow stylesheets to read and write files in the site directory #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xworld21 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow stylesheets to read and write files in the site directory #1951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/LaTeXML/Post/XSLT.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,16 @@ sub process {
if (my $icon = $params{ICON}) {
# Hmm.... what type? could be various image types
$params{ICON} = '"' . $self->copyResource($doc, $icon, undef) . '"'; }

# change directory so that files created by <exsl:document> are relative to the destination
my $destdir = $doc->getDestinationDirectory;
my $orig_cwd = pathname_cwd();
pathname_chdir($destdir);

my $newdoc = $doc->new($$self{stylesheet}->transform($doc->getDocument, %params));

pathname_chdir($orig_cwd);
Comment on lines +81 to +87
Copy link
Copy Markdown
Collaborator

@dginev dginev Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also suggest a defensive check that the change is needed / well-defined:

Suggested change
my $destdir = $doc->getDestinationDirectory;
my $orig_cwd = pathname_cwd();
pathname_chdir($destdir);
my $newdoc = $doc->new($$self{stylesheet}->transform($doc->getDocument, %params));
pathname_chdir($orig_cwd);
my $destdir = $doc->getDestinationDirectory;
my $orig_cwd = pathname_cwd();
my $needs_cwd_change = ($destdir ne $orig_cwd) && (-d $destdir);
pathname_chdir($destdir) if $needs_cwd_change;
my $newdoc = $doc->new($$self{stylesheet}->transform($doc->getDocument, %params));
pathname_chdir($orig_cwd) if $needs_cwd_change;

Copy link
Copy Markdown
Contributor Author

@xworld21 xworld21 Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we should also canonicalise the paths (especially if mixed path separators are involved) and emit an error/fatal if chdir fail.


return $newdoc; }

my $RESOURCE_INFO = { # [CONSTANT]
Expand Down