Add compact model and thinking controls for discovery and execution - #19
Open
tolimarchuk wants to merge 4 commits into
Open
tolimarchuk wants to merge 4 commits into
tolimarchuk wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 37 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 16 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add model and thinking controls for discovery and execution
Agency currently uses the coordinator's model for every phase. This adds separate model and thinking defaults for discovering ideas and executing approved work, with per-task overrides in New cards and New Task.
The controls stay compact: a small chip above task feedback opens the selectors, Settings keeps defaults in a collapsed Models row, and requested/actual worker details expand on demand. Unsaved or unavailable choices remain visible and block execution until resolved.
The model catalog comes from the installed runner. Approval freezes the selected configuration, dispatch prepares explicit model/thinking arguments with fresh context, and worker claims must match that configuration. Requested configuration and claimed worker metadata are recorded separately. Revision checks reject stale saves; later default changes cannot alter queued jobs. Unconfigured installations retain their existing coordinator workflow.
Task submission, decisions and completion each save their related records atomically. Conflicting updates leave neither partial task state nor stray audit rows.
Includes the database migration, catalog-sync and dispatch helpers, setup documentation, and regression coverage. The active coordinator still launches workers; this change does not install a background runner.
Validation:
Summary by cubic
Adds separate model and thinking controls for discovery and execution, replacing the old behavior of using the coordinator's model for every phase. Each New card and New Task can override the execution default; approval freezes the selected configuration and dispatch passes explicit model/thinking arguments with fresh context.
Migration
drizzle/0007_shocking_spectrum.sqlforagent_settingsand the new config/run columns.npm run models:syncto register the installed Codex runner's catalog; other runners can POST to/api/agent-models.Notes
Written for commit 68baaf6. Summary will update on new commits.