feat(docker): disable pattern check#7555
Open
badamowicz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
This PR addresses the issue mentioned in: #7541 (comment).
It's about having the possibility to disable the patterncheck for Dockerfiles. Therefore I added a new command line argument
--ignore-dockerfile-patternwhich only applies if also--fileis given and the framework isdockerfile.I'm not very happy with my solution because I am using an environment variable to disable the pattern. The reason I did it this way was that I found no better way to get the command line argument into the runner.
So if anybody can point me to a better way, this would be appreciated.
Checklist: