Skip to content

fix(terraform): guard against unhashable dict in CKV_AZURE_80 #7553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexanderSanin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(terraform): guard against unhashable dict in CKV_AZURE_80 #7553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions checkov/terraform/checks/resource/azure/AppServiceDotnetFrameworkVersion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def scan_resource_conf(self, conf) -> CheckResult:
site_config = conf.get('site_config')[0]
if site_config.get('dotnet_framework_version') and isinstance(site_config.get('dotnet_framework_version'), list):
version = site_config.get('dotnet_framework_version')[0]
if not isinstance(version, str):
return CheckResult.UNKNOWN
if version in supported_versions:
return CheckResult.PASSED
self.evaluated_keys = ['site_config/[0]/dotnet_framework_version']
Expand All @@ -31,6 +33,8 @@ def scan_resource_conf(self, conf) -> CheckResult:
stack = site_config.get('application_stack')[0]
if stack.get('dotnet_version') and isinstance(stack.get('dotnet_version'), list):
version = stack.get('dotnet_version')[0]
if not isinstance(version, str):
return CheckResult.UNKNOWN
if version in supported_versions:
return CheckResult.PASSED
self.evaluated_keys = ['site_config/[0]/application_stack/[0]/dotnet_version']
Expand Down
27 changes: 27 additions & 0 deletions tests/terraform/checks/resource/azure/example_AppServiceDotnetFrameworkVersion/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,33 @@ resource "azurerm_windows_web_app" "fail2" {
}
}

# UNKNOWN - dotnet_version is a non-string value (triggers CKV_AZURE_80 crash guard)
resource "azurerm_windows_web_app" "unknown" {
#checkov:skip=CKV_AZURE_16: AD might not be required
name = var.name
location = var.location
resource_group_name = var.rg_name
service_plan_id = var.service_plan_id

https_only = true

site_config {
application_stack {
dotnet_version = {}
}
}

client_certificate_enabled = true

auth_settings {
enabled = true
}

identity {
type = "SystemAssigned"
}
}

# IGNORE - no dotnet version specified
resource "azurerm_windows_web_app" "ignore" {
#checkov:skip=CKV_AZURE_16: AD might not be required
Expand Down