rendering: fix MSVC/clang-cl /WX conformance in the Vulkan renderer - #8
Merged
brianmk merged 1 commit intoSep 6, 2026
Conversation
The bundled Coin is built with COIN_STRICT_WARNINGS=OFF, so these warnings only surface on a Windows /WX build. Fix the class of issue clang-cl /W4 /WX turns into errors so the fork's Windows CI does not fail at the Coin compile step. - CMake: add -DNOMINMAX to the MSVC define block (windows.h leaks the min/max macros, breaking std::min/std::max via the Vulkan WSI headers) - SoVulkanShared: mark the unused VkAllocationCallbacks* param unused - RTX geometry: drop the unused 'mapped' lambda capture - RTX denoise: []() instead of [this]() + mark the diagnostic nrmR maybe_unused - RTX path tracing: mark the unused drawlist param unnamed - Vulkan frame: mark the unused raster reference maybe_unused - Render manager: mark the debug vkRenderBreadcrumb helper maybe_unused getenv C4996 needs nothing: the coin CMake if(MSVC) block already defines _CRT_SECURE_NO_WARNINGS. Verified with a Linux clang -Wall -Wextra -Werror scan of the Vulkan/RTX renderer (0 -Wunused-*) and a clang -Werror bundled build.
brianmk
changed the base branch from
fix/rt-light-transparency
to
perf/coown-ir-geometry-merged
September 6, 2026 05:00
brianmk
force-pushed
the
fix/vulkan-renderer-windows-conformance
branch
from
September 6, 2026 05:01
75e207f to
dcf6b4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundled Coin builds with COIN_STRICT_WARNINGS=OFF, so these only surface on Windows /WX. Fix the class clang-cl /W4 /WX turns into errors so the fork's Windows CI doesn't fail at the Coin compile step:
Verified with a Linux clang -Wall -Wextra -Werror scan of the Vulkan/RTX renderer (0 -Wunused-*) and a clang -Werror bundled build.