Repository navigation
Vulkan: drop the dead path-tracer surface and fix VMA's API version - #76
Merged
Merged
Conversation
The retained renderer is raster-only; the path-tracing backend was dropped at import, leaving dead references behind. - SoVulkanDeviceCaps: remove the six ray-tracing/NVIDIA capability fields (rayTracing, positionFetch, opacityMicromap, nvCluster, nvPartitioned, nvLinearSweptSpheres). They are never written or read by the renderer or the embedding app. - Reword the stale "RTX"/"path tracer"/"RT backend" comments in the retained-IR and raster sources (SoRenderIR, SoVulkanRenderManager, SoVulkanRenderBackend, SoVulkanRenderBackendP/Frame/Geometry, SoFnv1a) so the overlay-composite path reads as backend-agnostic rather than tied to the removed tracer. - VMA: initialize with the device's reported apiVersion (clamped to the 1.2 the backend targets) instead of hardcoding 1.2, so a Vulkan 1.0/1.1 device -- e.g. an older integrated GPU -- is not handed vkBindBufferMemory2 / vkGetBufferMemoryRequirements2 style entry points it does not support. - VulkanSmokeTest: report the physical device's real apiVersion in the device context, exercising the clamped VMA path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retained renderer is raster-only; the path-tracing backend was dropped at import, leaving dead references behind.
Changes
SoVulkanDeviceCaps: remove the six ray-tracing/NVIDIA capability fields (rayTracing,positionFetch,opacityMicromap,nvCluster,nvPartitioned,nvLinearSweptSpheres) — never written or read.SoRenderIR,SoVulkanRenderManager,SoVulkanRenderBackend(.h / P.h / Frame.cpp / Geometry.cpp)andSoFnv1a.h, so the overlay-composite path reads as backend-agnostic.SoVulkanRenderBackendCore.cpphardcodedvulkanApiVersion = VK_API_VERSION_1_2; it now uses the device's reported version clamped to 1.2, so a Vulkan 1.0/1.1 device (e.g. an older integrated GPU) is not handedvkBindBufferMemory2/vkGetBufferMemoryRequirements2entry points it does not support.apiVersionin the device context, exercising the clamped VMA path.Notes
SoVulkanDeviceCapsfields are also currently unused (externalSemaphoreFd,externalMemoryFd,timelineSemaphore,descriptorIndexingUpdateAfterBind). They look like intentionally-reserved interop/feature flags, so I left them; say the word and I'll trim those too.build-coin(Vulkan on, tests on) builds andVulkanSmokeTestpasses (one offscreen frame recorded).