Repository navigation
Condense the fork's Vulkan comments for upstream readability - #73
Merged
Merged
Conversation
Summarize the comment blocks this fork added over FreeCAD/coin (Vulkan renderer, IR, GL glue): keep invariants, lifetime/thread-safety and ordering contracts, perf rationale, API contracts, magic numbers and cross-references; drop filler and restatement. Comment-only change: comment-stripped code is byte-identical to coin-Integrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summarizes the comment blocks this fork added over upstream
FreeCAD/coin(the Vulkan renderer, retained-IR path, and GL glue) to make the diff easier to upstream.+1,909 / −4,325vscoin-Integrate5a4d2856); upstream-original comments untouched.What is kept
Comment-only rewrite; the important information is preserved:
Dropped: filler, hedging, repetition, and restatement of the obvious code.
Verification
Comment-stripped code is byte-identical to
coin-Integratein every modified file (strip//and/* */, compare with whitespace collapsed → 0 differing files).Left deliberately unchanged in ~25 files: license/copyright headers, the generated
*.spv.hDXC banners, and already-minimal one-line comments.Largest reductions
src/rendering/SoVulkanRenderManager.cppsrc/rendering/SoVulkanRenderBackend.h.../SoVulkanRenderBackendFrame.cpp.../SoVulkanRenderBackendCommand.cpp.../SoVulkanRenderBackendWideLine.cpp