Skip to content

fix(security): 2 improvements across 2 files #8424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andoan16 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(security): 2 improvements across 2 files #8424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1727a3
fix(security): 2 improvements across 2 files
andoan16 Apr 19, 2026
f493a53
fix(security): 2 improvements across 2 files
andoan16 Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/visual-editor/src/a2/google-drive/unescape.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ const namedEntities: Record<string, string> = {
// add more as needed
};

/**
* WARNING: This function decodes HTML entities including `<`, `>`, and `&`.
* The output must NEVER be inserted into the DOM via innerHTML without
* sanitization. Use textContent or a sanitization library like DOMPurify.
*/
function unescape(html: string): string {
return html.replace(unescapeTest, (_, n) => {
n = n.toLowerCase();
Expand Down
4 changes: 2 additions & 2 deletions packages/visual-editor/src/utils/make-share-link-from-template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export function makeShareLinkFromTemplate({
}: MakeShareLinkFromTemplate): string {
const url = new URL(
urlTemplate
.replaceAll("{fileId}", fileId)
.replaceAll("{resourceKey}", resourceKey ?? "")
.replaceAll("{fileId}", encodeURIComponent(fileId))
.replaceAll("{resourceKey}", resourceKey ? encodeURIComponent(resourceKey) : "")
);
// Remove any empty parameters. A slightly hacky way to clean up resourceKey
// parameters when there is no resourceKey.
Expand Down