Feature/eliminate toasts#279
Conversation
… different screen sizes
zuevval
added
enhancement
|
@winter-yuki please add your review. If you agree with changes, I will fix strings and mark this request as ready |
|
I liked the line on the braille dots background. I think we should not remove it |
There was a problem hiding this comment.
There is a strange inconsistency between the animation in the practice and old-style toasts in the theory. It'll be nice to have the same for theory. Maybe without the green part.
I liked the line on the braille dots background. I think we should not remove it.
Also, it will be great to have another BrailleDotsView class without dots to place it on show dots steps.
There is some work for auto reformatting.
| announce(announcement) | ||
| } | ||
|
|
||
| fun Fragment.announceCorrect() = announce(getString(R.string.input_correct)) |
There was a problem hiding this comment.
There is Messages.kt file for such kind of things
| } | ||
|
|
||
| fun animateView(obj: View?, colorFrom: Int?, colorTo: Int?) { | ||
| val duration = 1000 |
There was a problem hiding this comment.
Rathe be const val DURATION = 1000L
| } | ||
|
|
||
| @RequiresApi(Build.VERSION_CODES.LOLLIPOP) | ||
| private fun setBackgroundMode(mode: BrailleDotsViewMode) { |
There was a problem hiding this comment.
This thing looked good to me. I think it is still useful
| android:layout_marginEnd="@dimen/braille_dots_inner_horizontal_margin" | ||
| android:layout_marginBottom="@dimen/braille_dots_inner_vertical_margin" | ||
| android:contentDescription="@string/braille_dot_1" | ||
| android:text="@string/braille_dot_1_text" |
There was a problem hiding this comment.
Maybe it is better to replace with tools:text to prevent blinking.
|
Many thanks for a thorough review. I’ll consider everything. Some I will fix and other I’d maybe like to discuss in a short voice meeting next week if you will have some time, e. g. on Wednesday. |
|
For such kind of design topics, it is better to call @kaustika |
2 participants
Closes #278