Skip to content

fix: spd_set_notification must not always send NOTIFICATION ALL #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sthibaul merged 1 commit into from
Sep 1, 2026
Merged

fix: spd_set_notification must not always send NOTIFICATION ALL #1116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/api/c/libspeechd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,8 +1426,11 @@ spd_set_notification_off(SPDConnection * connection,
return -1;
}

/* SPD_ALL is the union of the six event bits rather than a bit of its own,
so every bit of val has to be set, not just one of them. For the
single-bit values the two tests are equivalent. */
#define NOTIFICATION_SET(val, ssip_val) \
if (notification & val){ \
if ((notification & (val)) == (val)){ \
sprintf(command, "SET SELF NOTIFICATION "ssip_val" %s", state);\
ret = spd_execute_command_wo_mutex(connection, command);\
if (ret < 0) RET(-1);\
Expand Down
Loading