feat(content-sidebar): route comment create/delete to threaded API when threadedRepliesV2 is on#4594
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
WalkthroughActivitySidebar now gates comment creation and deletion through threaded APIs when the ChangesThreaded Replies V2 Feature Gating
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
998751a to
70bc729
Compare
…en threadedRepliesV2 is on When activityFeed.threadedRepliesV2.enabled is on, createComment and deleteComment now route to createThreadedComment / deleteThreadedComment regardless of the legacy hasReplies prop, mirroring the existing gate on updateComment.
70bc729 to
dfd6c7e
Compare
Summary
activityFeed.threadedRepliesV2.enabledis on, routecreateCommentanddeleteCommentto the threaded comment API endpoints (createThreadedComment/deleteThreadedComment) regardless of the legacyhasRepliesprop.updateComment, so all three comment mutation methods now use the samehasReplies || isThreadedRepliesV2Enabledcondition.Test plan
yarn test --watchAll=false --testPathPattern="ActivitySidebar.test"(133 tests pass; 2 new cases cover V2-only routing)hasReplies=falseandthreadedRepliesV2.enabled=true, create a top-level comment and confirm the request hits the threaded comments endpointthreadedRepliesV2.enabled=false, confirm legacyhasRepliesbehavior is unchanged for both create and deleteSummary by CodeRabbit
New Features
Tests