feat(content-uploader): update fields in uploads response#4592
Conversation
WalkthroughThe changes introduce optional ChangesUpload Fields Query Parameter Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/api/uploads/PlainUpload.js`:
- Around line 77-79: The preflight path that assigns data.upload_url bypasses
the block that appends this.fields via updateQueryParameters, so fields aren't
added to preflight-provided upload URLs; modify the logic in PlainUpload.js
where uploadUrl is set from data.upload_url (and the branch handling preflight
responses) to always call updateQueryParameters(uploadUrl, { fields:
this.fields.toString() }) when this.fields is present (same behavior as the
existing branch), ensuring any code paths that set uploadUrl (including
data.upload_url) append the fields query parameter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c5085a6b-1dbb-4f0f-b003-58ec46b2f362
📒 Files selected for processing (7)
DEVELOPING.mdsrc/api/uploads/BaseUpload.jssrc/api/uploads/MultiputUpload.jssrc/api/uploads/PlainUpload.jssrc/constants.jssrc/elements/content-uploader/ContentUploader.tsxsrc/utils/fields.js
Merge Queue Status
This pull request spent 11 minutes 11 seconds in the queue, including 10 minutes 42 seconds running CI. Required conditions to merge
|
Summary by CodeRabbit
New Features
Chores