Skip to content

WIP: Relax potential by evolving phi rather than vort#570

Open
bendudson wants to merge 2 commits into
masterfrom
relax-potential-phi
Open

WIP: Relax potential by evolving phi rather than vort#570
bendudson wants to merge 2 commits into
masterfrom
relax-potential-phi

Conversation

@bendudson
Copy link
Copy Markdown
Collaborator

Adds a switch evolve_vorticity that is true by default, and equations are evolved for both phi and vort.
Setting evolve_vorticity to false modifies the equations so only phi is evolved and vort is calculated from phi. This reduces the size of the system and reduces the order of the PDE. Exploring whether this helps solve transport with drifts faster.

bendudson added 2 commits May 20, 2026 15:47
Rather than evolving both potential and vorticity equations, setting
`evolve_vorticity` to `false` evolves only potential.
Vorticity is now calculated from phi in `transform` rather than `finally`,
so additional permissions are needed.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.66%. Comparing base (2eeda48) to head (71d2c00).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/relax_potential.cxx 20.00% 32 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   48.64%   48.66%   +0.01%     
==========================================
  Files          96       96              
  Lines        9887     9896       +9     
  Branches     1435     1437       +2     
==========================================
+ Hits         4810     4816       +6     
+ Misses       4586     4585       -1     
- Partials      491      495       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant