WIP: Relax potential by evolving phi rather than vort#570
Open
bendudson wants to merge 2 commits into
Open
Conversation
Rather than evolving both potential and vorticity equations, setting `evolve_vorticity` to `false` evolves only potential.
Vorticity is now calculated from phi in `transform` rather than `finally`, so additional permissions are needed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 48.64% 48.66% +0.01%
==========================================
Files 96 96
Lines 9887 9896 +9
Branches 1435 1437 +2
==========================================
+ Hits 4810 4816 +6
+ Misses 4586 4585 -1
- Partials 491 495 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a switch
evolve_vorticitythat istrueby default, and equations are evolved for bothphiandvort.Setting
evolve_vorticitytofalsemodifies the equations so onlyphiis evolved andvortis calculated fromphi. This reduces the size of the system and reduces the order of the PDE. Exploring whether this helps solve transport with drifts faster.