When I am editing Exclude Items, it crashes

[vittuhy]

Description

When adding new Exclude Items, after closing the dialog it crashes. App stays open but this dialog pops up

Reproduction

• I tried to reproduce the issue.
• I was able to reproduce the issue.

OS

15.5 (24F74) MacOS

Version of Vorta

0.10.3

What did you install Vorta with?

Homebrew

Version of Borg

1.4.0

Logs

OS: Darwin
Release: 24.5.0
Version: Darwin Kernel Version 24.5.0: Tue Apr 22 19:54:43 PDT 2025; root:xnu-11417.121.6~2/RELEASE_ARM64_T8132
Date and Time: 2025-07-28 17:02:15
Borg Version: 1.4.0
Vorta Version: 0.10.3
Traceback (most recent call last):
  File "views/exclude_dialog.py", line 309, in custom_pattern_editing_finished
  File "views/exclude_dialog.py", line 305, in text_editing_finished
AttributeError: 'NoneType' object has no attribute 'text'

[VandalByte]

Hey @vittuhy
Could you explain a bit on how you were able to reproduce this issue? I tried adding a new item in Custom list with the plus button typed something then closed that dialog box but didn't encounter any error like you mentioned.

[andrewcrook]

So I think I can replicate it, I dont know if the steps are slightly different or not from you

1. open exclude dialog
2. Add new item leave it blank
3. uncheck it
4. close
5. open dialog again
6. add new item a path
7. now click outside the Vorta window
8. it should crash with the following error

So I get error

OS: Darwin
Release: 24.6.0
Version: Darwin Kernel Version 24.6.0: Mon Jul 14 11:30:34 PDT 2025; root:xnu-11417.140.69~1/RELEASE_ARM64_T8103
Date and Time: 2025-08-03 15:22:29
Borg Version: 1.4.1
Vorta Version: 0.10.3
Traceback (most recent call last):
  File "views/exclude_dialog.py", line 309, in custom_pattern_editing_finished
  File "views/exclude_dialog.py", line 305, in text_editing_finished
AttributeError: 'NoneType' object has no attribute 'text'

line 309

 def custom_pattern_editing_finished(self, editor):
        self.text_editing_finished(self.customExclusionsModel)

calls function ext_editing_finished()

line 305

    def text_editing_finished(self, model):
        '''
        Go through all items in the list and if any of them are empty, remove them.
        Handles the case where the user presses the escape key to cancel editing.
        '''
        for row in range(model.rowCount()):
            item = model.item(row)        <<<-  a item can not be None (Null object)
            if item.text() == ‘':                 <<<-   and a string should not be empty or blank
                model.removeRow(row)

I think there are a couple of issues

1. a disabled empty/blank item needs to be removed, an enabled empty item is currently removed.
2. line 305 if the item in ‘model.item(row)' is none then there is no object to have methods like .text() to test with (this was the main error)
3. also line 305 only tests for empty strings it also needs to test for just a space or spaces i.e a blank string
   • empty if it’s either null (None) or a string without any length
   • If a string only consists of whitespace characters (space, tabs, etc), then it is a blank string.
4. also test events around when the dialog loses focus.

OS
macOS: 15.6 (24G84)

Version of Vorta
0.10.3

What did you install Vorta with?
Homebrew

Version of Borg
1.4.1

[andrewcrook]

Might help

def is_null_or_blank(s):
    return s is None or s.strip() == ''

def text_editing_finished(self, model):
        ‘’'
        Go through all items in the list and if any of them are empty, remove them.
        Handles the case where the user presses the escape key to cancel editing.
        ‘’'
        for row in range(model.rowCount()):
            item = model.item(row)
            if item is None or is_null_or_blank(item.text()):       
                model.removeRow(row)

[VandalByte]

Since it was a small fix I've included it along with another PR #2252. It should be patched once it's merged. Thanks for reporting the issue, guys.

[andrewcrook]

@VandalByte no problem I hope it’s the same issue that @vittuhy had. I think it is.

I would test for blank strings as well s.strip() == ‘’ just to be complete

[VandalByte]

@andrewcrook
I saw that you mentioned that in your last comment and I was actually looking into it but haven't been able to get it working yet. It's working fine for the checked ones but the ones that are unchecked, once editing is finished it goes away but when you open the exception dialog again there's a blank entry at the top.

def text_editing_finished(self, model):
        '''
        Go through all items in the list and if any of them are empty, remove them.
        Handles the case where the user presses the escape key to cancel editing.
        '''
        for row in range(model.rowCount()):
            item = model.item(row)
            if item is not None and item.text().strip() == '':
                model.removeRow(row)

[VandalByte]

Interestingly while I was going through that I found this, wrong model is used.

vorta/src/vorta/views/exclude_dialog.py

Lines 374 to 376 in 7ccb27d

	def exclude_if_present_pattern_editing_finished(self, editor):
	self.text_editing_finished(self.customExclusionsModel)
	self.save_exclude_if_present_patterns()

[VandalByte]

@andrewcrook I saw that you mentioned that in your last comment and I was actually looking into it but haven't been able to get it working yet. It's working fine for the checked ones but the ones that are unchecked, once editing is finished it goes away but when you open the exception dialog again there's a blank entry at the top.

def text_editing_finished(self, model):
'''
Go through all items in the list and if any of them are empty, remove them.
Handles the case where the user presses the escape key to cancel editing.
'''
for row in range(model.rowCount()):
item = model.item(row)
if item is not None and item.text().strip() == '':
model.removeRow(row)

I have created a new issue to address this issue.