Add --virtiofsd CLI option and VIRTIOFSD_BIN env var support#266
Open
nickryand wants to merge 3 commits into
Open
Add --virtiofsd CLI option and VIRTIOFSD_BIN env var support#266nickryand wants to merge 3 commits into
nickryand wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to explicitly specify the path to the virtiofsd binary via a new configuration option, a --virtiofsd CLI flag, and a VIRTIOFSD_BIN environment variable. This allows users to override the default auto-detection logic. The changes span the virtiofsd spawning logic in bcvk-qemu and the CLI argument handling in kit. Feedback suggests improving error handling by verifying the existence of the user-provided path immediately and addressing potential path resolution or accessibility issues when the binary is used within a containerized environment.
nickryand
force-pushed
the
push-kpxpkoswxpww
branch
from
c939cff to
2a50a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should close out #265.