Fix Config Loading + Base Dirs CLI Flag - #60
Merged
Conversation
…allsback to defaults as expected
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Bagel’s configuration-loading behavior so scans can proceed when auto-discovered configs are missing/unreadable, and adds a scan CLI flag to override file-index base directories.
Changes:
- Update
config.Loadto treat auto-discovery config read failures as non-fatal while keeping explicit--configfailures fatal. - Add unit tests covering missing config, unusable discovered config, and explicit config failure behavior.
- Add
--base-dirsflag tobagel scanto overridefile_index.base_dirsfrom configuration.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/config/config.go | Refines ReadInConfig error handling (fallback vs. fail loudly) and adds logging. |
| pkg/config/config_test.go | Adds tests to lock in the new config-loading contracts. |
| cmd/bagel/scan.go | Introduces --base-dirs flag and applies it to the loaded config before scanning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SUSTAPLE117
marked this pull request as ready for review
June 17, 2026 13:24
fproulx-boostsecurity
approved these changes
Jun 17, 2026
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.