Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, localized to the sorting UI, and integrates with the existing sort_by selection mechanism without introducing additional logic.
Pull request overview
Extends the collection product sorting selector to include a “popularity” sort option, enabling users to sort products by popularity via the existing sort_by query parameter flow.
Changes:
- Adds a new
<option>to the sorting dropdown withvalue="popularity". - Uses a new translation key (
store.sorting_popularity) for the option label.
File summaries
| File | Description |
|---|---|
| snippets/sorting-select.liquid | Adds a “popularity” option to the existing sorting <select> so it can be chosen and reflected as the selected value. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
JKinnez
changed the title
There was a problem hiding this comment.
🟡 Changes recommended
The selector may display the wrong sort after reload because its selected-state check mismatches the submitted value.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
dabrorius
self-requested a review
September 15, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the product sorting selector with popularity option.
Shop: Update sorting options Part 2