Skip to content

remove point and version for accessibility#8

Open
patrick-emmabuntus wants to merge 2 commits intobook-readers:mainfrom
patrick-emmabuntus:main
Open

remove point and version for accessibility#8
patrick-emmabuntus wants to merge 2 commits intobook-readers:mainfrom
patrick-emmabuntus:main

Conversation

@patrick-emmabuntus
Copy link
Copy Markdown

Hi @sthibaul

The Pull Request for this ticket #7 for only this points :

  • Remove the periods between the chapter titles and the page number
  • Remove the version, the name of the author in the top banner

For this point :

  • Filter the files jeg, opf, displayed in the file explorer

I can make this modification, but there is an impact because future users will not be able to see certain files in ebook-speaker's file explorer.

@sthibaul
Copy link
Copy Markdown
Member

* Filter the files jeg, opf, displayed in the file explorer

I can make this modification, but there is an impact because future users will not be able to see certain files in ebook-speaker's file explorer.

That's precisely why I asked the separate pull request :) Please make it so we can discuss about it there.

Comment thread src/ebook-speaker.c
waddstr (misc->screenwin, " ");
for (x = l; x < 56; x += 2)
waddstr (misc->screenwin, " .");
waddstr (misc->screenwin, " ");
Copy link
Copy Markdown
Member

@sthibaul sthibaul Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we are going to display only spaces, please replace this 2-by-2 loop and the previous if with a single 1-by-1 loop.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can do that.

@sthibaul
Copy link
Copy Markdown
Member

Remove the periods between the chapter titles and the page number

I wonder what people think about it: are these periods useful? It's clearly a burden for Orca so it's probably worth dropping them, I wonder if they have some use (except for sighted users for whom they may be convenient to track lines, but not sure if it's really that useful?)

@patrick-emmabuntus
Copy link
Copy Markdown
Author

Yes this is a problem for Orca, and not very useful for visually impaired users.

If you are unsure, you can add a command line option to not put them.

@patrick-emmabuntus
Copy link
Copy Markdown
Author

I can make this modification, but there is an impact because future users will not be able to see certain files in ebook-speaker's file explorer.

That's precisely why I asked the separate pull request :) Please make it so we can discuss about it there.

I put this here but I can't see how to do the pull request to put this.

cacb9f0

@sthibaul
Copy link
Copy Markdown
Member

You can create another branch in your repository, to create another pull request from that

juanma1980 added a commit to lliurex/ebook-speaker that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants