fix(core): seed multiline prompt with initialValue#570
Closed
spokodev wants to merge 1 commit into
Closed
Conversation
The multiline prompt accepted `initialValue` but never seeded the editor with it, unlike the text prompt, so passing it had no effect. Forward `initialValue` (falling back to `initialUserInput`) to the base Prompt so the value is present when the prompt opens. Closes bombshell-dev#566
🦋 Changeset detectedLatest commit: 38f597d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
thanks for the contribution 🙏 but this is already being fixed in the earlier #569 PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #566.
multilineacceptsinitialValuebut never seeded the editor with it, so passing it had no effect — the prompt always opened empty.TextPromptforwardsinitialValueto the basePromptasinitialUserInput;MultiLinePromptdid not. This mirrors that single line in theMultiLinePromptconstructor, so the editor opens pre-filled and an unedited submit returns the seeded value (falling back toinitialUserInput).Tests
Two
@clack/coretests, red before the change and green after:initialValueinto the editor (userInput+value)initialValuewhen not editedFull
@clack/coresuite: 143 passing. Changeset included (@clack/corepatch).