Skip to content

fix: normalize password prompt empty submit to empty string (#560)#561

Merged
43081j merged 1 commit into
bombshell-dev:mainfrom
avallete:fix/560-password-resolve-undefined
Jun 15, 2026
Merged

fix: normalize password prompt empty submit to empty string (#560)#561
43081j merged 1 commit into
bombshell-dev:mainfrom
avallete:fix/560-password-resolve-undefined

Conversation

@avallete

Copy link
Copy Markdown
Contributor

What does this PR do?

The password prompt resolved to undefined on empty submit instead of empty string. Normalize the value on finalize to match the text prompt and the documented Promise<string | symbol> return type.

Closes #560

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

…l-dev#560)

The password prompt resolved to undefined on empty submit instead of empty string.
Normalize the value on finalize to match the text prompt and the documented
Promise<string | symbol> return type.
@changeset-bot

changeset-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a1ca64d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clack/core Patch
@clack/prompts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jun 15, 2026

Copy link
Copy Markdown

commit: a1ca64d

@43081j 43081j merged commit 2f2b52f into bombshell-dev:main Jun 15, 2026
11 checks passed
@bombshell-bot bombshell-bot Bot mentioned this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] password prompt resolves undefined on empty submit

2 participants