Skip to content

refactor(wayland): use go-wayland-bindings for protocol bindings - #5

Closed
bnema wants to merge 1 commit into
mainfrom
refactor/wayland-bindings
Closed

bnema wants to merge 1 commit into
mainfrom
refactor/wayland-bindings

Conversation

@bnema

@bnema bnema commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner

First PR of a stack; #6 builds on it.

Summary

wlturbo moved its protocol bindings to go-wayland-bindings, and newer wlturbo releases no longer ship them. The wayland adapter now imports the same generated packages from go-wayland-bindings v0.1.0. The APIs are identical (checked package by package), so only import paths change. The local package names (core, imagecapturesource, ...) are kept to avoid touching call sites.

AuthorizeLayer takes the layer's wl_surface as a wlturbo.Proxy, so a surface created by any bindings on the same display works (#6 passes neferclient's). A typed nil proxy is rejected like a nil one, with a test.

This PR still builds against nefergui v0.3.0: it changes no behaviour.

Checks

make check, make race, make mocks-check, staticcheck

wlturbo moved its protocol bindings to go-wayland-bindings; newer
wlturbo releases no longer ship them. The wayland adapter now imports
the same generated packages from go-wayland-bindings v0.1.0. The APIs
are identical, so only import paths change.

AuthorizeLayer takes the layer's wl_surface as a wlturbo.Proxy, so a
surface created by any bindings on the same display can be authorized.
A typed nil proxy is rejected like a nil one.
@bnema
bnema added this pull request to stack #7 October 2, 2026 04:01
@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant