Repository navigation
Conversation
wlturbo moved its protocol bindings to go-wayland-bindings; newer wlturbo releases no longer ship them. The wayland adapter now imports the same generated packages from go-wayland-bindings v0.1.0. The APIs are identical, so only import paths change. AuthorizeLayer takes the layer's wl_surface as a wlturbo.Proxy, so a surface created by any bindings on the same display can be authorized. A typed nil proxy is rejected like a nil one.
bnema
added this pull request to stack #7
October 2, 2026 04:01
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR of a stack; #6 builds on it.
Summary
wlturbo moved its protocol bindings to go-wayland-bindings, and newer wlturbo releases no longer ship them. The wayland adapter now imports the same generated packages from go-wayland-bindings v0.1.0. The APIs are identical (checked package by package), so only import paths change. The local package names (
core,imagecapturesource, ...) are kept to avoid touching call sites.AuthorizeLayertakes the layer'swl_surfaceas awlturbo.Proxy, so a surface created by any bindings on the same display works (#6 passes neferclient's). A typed nil proxy is rejected like a nil one, with a test.This PR still builds against nefergui v0.3.0: it changes no behaviour.
Checks
make check,make race,make mocks-check,staticcheck