feat(aggregator): own subnet + one neighbor for --aggregate-subnet-ids#175
Open
ch4r10t33r wants to merge 2 commits into
Open
feat(aggregator): own subnet + one neighbor for --aggregate-subnet-ids#175ch4r10t33r wants to merge 2 commits into
ch4r10t33r wants to merge 2 commits into
Conversation
Each aggregator passes --aggregate-subnet-ids as {i,(i+1) mod N}
instead of 0..N-1, cutting gossip fan-in per node (see zeam#863).
- Add compute-aggregate-subnet-ids.sh (shared by parse-vc.sh and Ansible)
- Zeam/ethlambda roles: per-host CSV via helper (no run_once)
- Update client-cmd comments to match new semantics
compute-aggregate-subnet-ids.sh no longer appends a neighbor subnet, so client-cmds and Ansible stop passing --aggregate-subnet-ids for the usual one-aggregator-per-subnet layout; gossip follows validator-derived subnets. Update comments in parse-vc, roles, and client wrappers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aggregators previously received
--aggregate-subnet-ids 0,1,...,N-1everywhere, so each gossip attestation was duplicated across every subscribed subnet topic. That contributed to libxev thread load on multi-subnet devnets (context: blockblaz/zeam#863).This change gives each aggregator its own attestation subnet plus exactly one neighbor: subnet
isubscribes to\{i, (i+1) mod N\}. Every subnet still has at least two aggregators (native + previous subnet's neighbor). Per-aggregator topic count drops fromNto2whenN ≥ 2(e.g. four subnets → two topics per aggregator).Changes
compute-aggregate-subnet-ids.sh: shared helper; prefers per-rowsubnet:, elsevalidator_index % attestation_committee_count(aligned withspin-node.sh_node_subnet).parse-vc.sh: buildsaggregateSubnetIdsper node via the helper (local /spin-node.sh).zeam,ethlambdaroles): same helper, per host (norun_once) so each deployed aggregator gets the correct pair.client-cmds/*: comment updates only; existingisAggregator && CSV contains ,guard unchanged.Notes
N = 1: output is a single id (no comma); clients omit--aggregate-subnet-idsas before.N = 2: result is still0,1for every node (same as old global CSV).