fix(ansible): per-play strategy=free; compatible with add_host#174
Open
ch4r10t33r wants to merge 1 commit into
Open
fix(ansible): per-play strategy=free; compatible with add_host#174ch4r10t33r wants to merge 1 commit into
ch4r10t33r wants to merge 1 commit into
Conversation
Global strategy=free in ansible.cfg breaks playbooks that call add_host (deploy-nodes, stop-nodes, clean-node-data, copy-genesis). Remove it from ansible.cfg and set strategy: free only on plays that do not use add_host. Update README, site.yml, and group_vars comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ansible fails when
ansible.cfgsets globalstrategy = freeand a playbook usesadd_host:This affected
stop-nodes.yml,deploy-nodes.yml,clean-node-data.yml, andcopy-genesis.yml(dynamic groups viaadd_host).Change
strategy = freefromansible/ansible.cfg(keepforkstuning and document the constraint).strategy: freeonly on plays that do not useadd_host:prepare.yml, remote deploy/sync plays indeploy-nodes.yml,stop-nodes.ymlremote play,clean-node-data.ymlremote play.ansible/README.md,site.ymlheader, andinventory/group_vars/all.ymlcomments.Verification
ansible-playbook --syntax-checkon the touched playbooks passes.