Add pattern #26 for replies that re-explain shared context (#269) - #271
Open
Kutomore wants to merge 1 commit into
Open
Add pattern #26 for replies that re-explain shared context (#269)#271Kutomore wants to merge 1 commit into
Kutomore wants to merge 1 commit into
Conversation
|
Clean and minimal — appreciate that it stays scoped to the actual fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #269.
Problem
Humanizer can remove every sentence-level tell from a conversational reply and still leave it sounding like a generated memo. The example in #269 opens by restating the problem, works through the diagnosis, adds a query and QA counts to show a backfill is feasible, and only then gives the decision. Every sentence is fine on its own, so no current pattern catches it. The reply the issue author actually posted was less than half as long: the decision, plus the one reason it was out of scope.
The core rule, "add something the reader did not already have," only looked at the text being rewritten. In a reply, most of what the model rebuilds is already shared by the other person in the thread.
Change
I added a pattern instead of folding this into an existing one because every other pattern reads the text in isolation and this one needs the thread. Putting #26 in a new short section also keeps 1 through 25 unrenumbered.
Validation
Two blind runs of the updated skill. Each run got only the input and the rule file, not the target rewrite.
Run 1: a reply, thread visible
Context given to the skill: this is a reply in a code review thread. The reviewer has already agreed the change is a workaround and has suggested fixing the underlying bug and backfilling the old data.
Input
The skill marked #26 as the main tell, with #1 (not-X-but-Y) and #9 (stacked qualifiers) alongside it.
Output
The decision comes first, the
Change.where(...)query and the "123 merge events" count are gone, and the fix location is down to one sentence. The one fact the reviewer did not have, the 6-record count, stays. The result is about 90 words against 180 in the input, close to the reply the issue author wrote by hand.Run 2: the same content as a standalone note
Input
The skill did not fire #26. Its note: "this is a standalone engineering note, not a reply, so the full explanation is appropriate." It kept the diagnosis, the query, and the counts, and changed only sentence-level tells (#3 "The real fix is in", #11 passive voice).
Package checks
python3 scripts/validate-package.pypasses.SKILL.mdis 392 lines.