[PM-34147] Add GetManyConfirmedAndAcceptedDetailsByUserAsync to IOrganizationUserRepository#7399
Open
[PM-34147] Add GetManyConfirmedAndAcceptedDetailsByUserAsync to IOrganizationUserRepository#7399
Conversation
…nizationUserRepository.
Contributor
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds Code Review DetailsNo findings identified. The change is well-structured and follows existing codebase conventions. |
JimmyVo16
commented
Apr 6, 2026
| { | ||
| var dbContext = GetDatabaseContext(scope); | ||
| var view = new OrganizationUserOrganizationDetailsViewQuery(); | ||
| var t = await (view.Run(dbContext)).ToArrayAsync(); |
Contributor
Author
There was a problem hiding this comment.
This isn’t related to my PR, but it’s dead code and not being used. It was introduced about five years ago. Since AC owns this code now, I think we should remove it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7399 +/- ##
==========================================
+ Coverage 58.43% 62.60% +4.17%
==========================================
Files 2060 2060
Lines 91214 91293 +79
Branches 8119 8131 +12
==========================================
+ Hits 53304 57158 +3854
+ Misses 36018 32155 -3863
- Partials 1892 1980 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (121)Checkmarx found the following issues in this Pull Request
|
|
Contributor
Author
|
I'm looking into Checkmarx. I feel like it's a false positive since I'm using an established pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34147
📔 Objective
📸 Screenshots
Migration was successful.