Open
Conversation
Contributor
|
New Issues (121)Checkmarx found the following issues in this Pull Request
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7398 +/- ##
==========================================
- Coverage 58.42% 58.42% -0.01%
==========================================
Files 2063 2063
Lines 91182 91168 -14
Branches 8129 8127 -2
==========================================
- Hits 53276 53262 -14
Misses 36008 36008
Partials 1898 1898 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR removes the server-side 6-record sampling limit from the organization report summary endpoint, allowing it to return all entries within the requested date range. The removed Code Review DetailsNo findings. The change is well-scoped: it removes server-side grouping logic as described in the objective, preserves all existing validation and caching behavior, and updates tests appropriately. |
lastbestdev
approved these changes
Apr 7, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-34686
📔 Objective
The Access Intelligence risk-over-time graph widget (PM-26961) requires time-series data to display trends for applications, passwords, and members at-risk over various time periods.
In PM-28531, the server-side endpoint GET /reports/organizations/{organizationId}/data/summary was created to serve this data. The original implementation grouped summaries by time period and limited the response to six data points — matching the chart's planned display of six evenly-spaced x-axis points.
During team review, the server-side grouping seemed limited. The decision has been made to remove the six-summary constraint so the endpoint returns all summaries within the requested date range. If grouping or sampling is needed in the future, it will be handled on the client side.
Current State
The endpoint currently applies grouping logic that limits the response to six OrganizationReportSummaryModel entries regardless of how many records exist in the requested date range.
📸 Screenshots