[PM-34146] Add stored procedures for accepted users#7392
Open
[PM-34146] Add stored procedures for accepted users#7392
Conversation
Contributor
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds a new Code Review DetailsNo findings. The implementation correctly follows established repository patterns, maintains dual-ORM parity, and includes comprehensive test coverage. |
JimmyVo16
commented
Apr 6, 2026
| /// WARNING: do not use this to enforce policies against a user! It returns raw data and does not take into account | ||
| /// various business rules. Use <see cref="IPolicyRequirementQuery"/> instead. | ||
| /// </remarks> | ||
| Task<Policy?> GetByOrganizationIdTypeAsync(Guid organizationId, PolicyType type); |
Contributor
Author
There was a problem hiding this comment.
@eliykat Not related to this ticket, but should we consider adding more context to this name, or do we feel that we can safely assume that it implies it’s only for confirmed users?
Member
There was a problem hiding this comment.
I always like being explicit. You could add more context via xmldoc or changing its name to mention Confirmed, provided the blast radius isn't too large for this PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7392 +/- ##
==========================================
+ Coverage 62.58% 62.59% +0.01%
==========================================
Files 2060 2061 +1
Lines 91184 91248 +64
Branches 8114 8119 +5
==========================================
+ Hits 57069 57120 +51
- Misses 32144 32154 +10
- Partials 1971 1974 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (113)Checkmarx found the following issues in this Pull Request
Fixed Issues (8)Great job! The following issues were fixed in this Pull Request
|
JimmyVo16
changed the title
|
JimmyVo16
commented
Apr 6, 2026
| Items = phase1.Items.Select(i => new SubscriptionSchedulePhaseItemOptions | ||
| { | ||
| Price = i.PriceId, Quantity = i.Quantity | ||
| Price = i.PriceId, |
Contributor
Author
There was a problem hiding this comment.
This broke the linter pipeline earlier. It’s not related to my change, but I’m happy to keep it to keep things moving unless the billing team wants to merge their own fix into main.
cc: @bitwarden/team-billing-dev
Collaborator
There was a problem hiding this comment.
Nope that's perfectly fine. Thanks for the fix!
sbrown-livefront
approved these changes
Apr 6, 2026
Contributor
Author
|
I'm looking into Checkmarx. I feel like it's a false positive since I'm using an established pattern. |
sven-bitwarden
approved these changes
Apr 7, 2026
Contributor
Author
|
Talked to Matt Andreko about Checkmarx, and this is a false positive. We’re looking into moving to a new system in the near future. |
mkincaid-bw
reviewed
Apr 7, 2026
| @@ -0,0 +1,18 @@ | |||
| CREATE PROCEDURE [dbo].[Policy_ReadByUserIdWithConfirmedAndAccepted] | |||
Contributor
There was a problem hiding this comment.
We want to avoid using And in proc names (see note: "Do not use And between parameter names in procedure names"):
https://contributing.bitwarden.com/contributing/code-style/sql/#common-examples
mkincaid-bw
reviewed
Apr 7, 2026
| @@ -0,0 +1,25 @@ | |||
| IF OBJECT_ID('[dbo].[Policy_ReadByUserIdWithConfirmedAndAccepted]') IS NOT NULL | |||
Contributor
There was a problem hiding this comment.
This should use CREATE OR ALTER instead of DROP/CREATE
https://contributing.bitwarden.com/contributing/code-style/sql/#creating-or-modifying-a-function-or-stored-procedure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34146
📔 Objective
📸 Screenshots
Migration was successful.
