[PM-33501] Prevent orphaned Sends during user and org deletion#7386
Open
[PM-33501] Prevent orphaned Sends during user and org deletion#7386
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7386 +/- ##
==========================================
+ Coverage 62.58% 62.64% +0.06%
==========================================
Files 2060 2064 +4
Lines 91184 91372 +188
Branches 8114 8144 +30
==========================================
+ Hits 57069 57244 +175
+ Misses 32144 32142 -2
- Partials 1971 1986 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (123)Checkmarx found the following issues in this Pull Request
|
itsadrago
previously approved these changes
Apr 3, 2026
rkac-bw
reviewed
Apr 3, 2026
| [dbo].[OrganizationReport] | ||
| WHERE | ||
| [OrganizationId] = @Id | ||
| -- Delete Organization Owned Sends |
Contributor
There was a problem hiding this comment.
⛏️ Differs in formatting, add blank line before comment
itsadrago
previously approved these changes
Apr 3, 2026
r-tome
previously approved these changes
Apr 6, 2026
Contributor
r-tome
left a comment
r-tome
left a comment
There was a problem hiding this comment.
AC changes look good! I just left a non-blocking suggestion
| } | ||
| } | ||
|
|
||
| var sends = await _sendRepository.GetManyByOrganizationIdAsync(organization.Id); |
Contributor
There was a problem hiding this comment.
⛏️ : Moving this to a private method would make this easier to read
Contributor
Author
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR prevents orphaned Send files during user and organization deletion by ensuring blob storage files are deleted before their corresponding database records. The fix in Code Review DetailsNo findings requiring inline comments. The implementation is consistent across all three deletion paths (org delete, user delete, individual send delete), null handling is correct, and the SQL migration aligns with the EF changes. |
itsadrago
approved these changes
Apr 6, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33501
📔 Objective
This PR resolves the possibility of Sends becoming orphaned during user or organization deletion. It is worth noting that Sends aren't currently associated with organizations, but this functionality is planned, and code in this PR is intended to support the complete removal of Send data associated to a deleted organization.