Skip to content

[PM-32131] Add UseMyItems organization ability#7014

Merged
eliykat merged 38 commits intomainfrom
ac/pm-32131/server-add-usemyitems-organization-ability
Feb 25, 2026
Merged

[PM-32131] Add UseMyItems organization ability#7014
eliykat merged 38 commits intomainfrom
ac/pm-32131/server-add-usemyitems-organization-ability

Conversation

@eliykat
Copy link
Copy Markdown
Member

@eliykat eliykat commented Feb 17, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32131

📔 Objective

Add a UseMyItems organization ability. This can be manually toggled off in the Bitwarden Portal in order to disable the creation of My Items when using the Organization Data Ownership policy. It will be on by default and only disabled upon customer request.

This PR adds the ability, handles setting the default value, and allows it to be manually overridden. It does not wire it up to any business logic yet.

This was added following the instructions in #6970.

Design decision
We could structure this as UseMyItems (positive) or DisableMyItems (negative). I went with UseMyItems because:

  • My Items is a feature, and this follows the pattern of all other features (i.e. we have UseSso, not DisableSso)
  • it's conceptually clearer to "enable or disable the feature" rather than "enable the flag that disables the feature" (inverted)

Summary of changes

  • new organization table column with all sprocs and views updated
  • data migration to enable the feature for all organizations that already use policies (replicating existing behaviour)
    • note: most LOC changes are due to autogenerated db migrations, but open to feedback if this PR needs to be split up
  • data and api models updated
  • added to organization license file so it can be preserved in self-hosted instances
  • note that we don't have a plan feature defined for this yet, so it is set based on UsePolicies to match the migration logic. Billing Team have a ticket to add this, and I have marked the affected locations with TODOs, including ticket reference.

📸 Screenshots

@eliykat eliykat changed the title Ac/pm 32131/server add usemyitems organization ability [PM-32131] Add UseMyItems organization ability Feb 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 17, 2026

Logo
Checkmarx One – Scan Summary & Details1895540c-091e-4a39-9db0-351a08fd9148

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 60.78431% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.70%. Comparing base (5c77ae9) to head (8bc5736).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...Admin/AdminConsole/Models/OrganizationEditModel.cs 8.33% 11 Missing ⚠️
...dminConsole/Controllers/OrganizationsController.cs 20.00% 3 Missing and 1 partial ⚠️
...illing/Organizations/Models/OrganizationLicense.cs 50.00% 3 Missing ⚠️
...lling/Providers/Services/ProviderBillingService.cs 0.00% 1 Missing ⚠️
.../Core/AdminConsole/Services/OrganizationFactory.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7014      +/-   ##
==========================================
+ Coverage   56.69%   60.70%   +4.00%     
==========================================
  Files        2013     2013              
  Lines       88125    88171      +46     
  Branches     7848     7851       +3     
==========================================
+ Hits        49965    53524    +3559     
+ Misses      36341    32744    -3597     
- Partials     1819     1903      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eliykat eliykat removed the request for review from rkac-bw February 18, 2026 02:58
rkac-bw
rkac-bw previously approved these changes Feb 18, 2026
Copy link
Copy Markdown
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

r-tome
r-tome previously approved these changes Feb 18, 2026
sven-bitwarden
sven-bitwarden previously approved these changes Feb 18, 2026
kdenney
kdenney previously approved these changes Feb 18, 2026
@eliykat eliykat dismissed stale reviews from kdenney, sven-bitwarden, r-tome, and rkac-bw via 8bc5736 February 24, 2026 04:36
@eliykat eliykat removed the needs-qa label Feb 24, 2026
@sonarqubecloud
Copy link
Copy Markdown

@eliykat eliykat requested review from kdenney, r-tome, rkac-bw and sven-bitwarden and removed request for sven-bitwarden February 24, 2026 07:38
@eliykat
Copy link
Copy Markdown
Member Author

eliykat commented Feb 24, 2026

This is ready for merge, I just had to bump migration dates as I'd been overtaken on main.

@eliykat eliykat enabled auto-merge (squash) February 25, 2026 02:50
@eliykat eliykat merged commit e3c392b into main Feb 25, 2026
55 of 57 checks passed
@eliykat eliykat deleted the ac/pm-32131/server-add-usemyitems-organization-ability branch February 25, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants