remove unused globalSettings parameter from send responses#6016
Closed
audreyality wants to merge 2 commits intomainfrom
Closed
remove unused globalSettings parameter from send responses#6016audreyality wants to merge 2 commits intomainfrom
globalSettings parameter from send responses#6016audreyality wants to merge 2 commits intomainfrom
Conversation
djsmith85
previously approved these changes
Jul 1, 2025
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6016 +/- ##
==========================================
+ Coverage 47.83% 47.84% +0.01%
==========================================
Files 1700 1702 +2
Lines 75484 75532 +48
Branches 6794 6799 +5
==========================================
+ Hits 36107 36142 +35
- Misses 37911 37923 +12
- Partials 1466 1467 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (5)Checkmarx found the following issues in this Pull Request
Fixed Issues (14)Great job! The following issues were fixed in this Pull Request
|
|
djsmith85
requested changes
Aug 18, 2025
Contributor
djsmith85
left a comment
djsmith85
left a comment
There was a problem hiding this comment.
This should only be removing the usage of unused globalSettings. The last commit (5f84072) introduces the new ISendOwnerQuery which was created for #5895. I think this might have been a bad merge/push.
You could either update this PR and we'll get it merged quickly, or close this and include the clean up on #5895
auto-merge was automatically disabled
August 18, 2025 12:47
Pull request was closed
audreyality
deleted the
tools/tech-debt/remove-unused-response-parameters
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
#5895 - code review feedback
📔 Objective
Remove unused
globalSettingsparameter from send responses⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes