Skip to content

Fix exlcusiveMaximum and exclusiveMinimum to be number type instead o… - #135

Merged
jgperrin merged 10 commits into
bitol-io:devfrom
pflooky:feature/exclusive-update
Aug 13, 2025
Merged

Fix exlcusiveMaximum and exclusiveMinimum to be number type instead o…#135
jgperrin merged 10 commits into
bitol-io:devfrom
pflooky:feature/exclusive-update

Conversation

@pflooky

@pflooky pflooky commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

…f boolean, create script to show diff between JSON schema version for pull request

@pflooky
pflooky force-pushed the feature/exclusive-update branch 2 times, most recently from 9e18025 to 06aff67 Compare July 27, 2025 09:16
@pflooky

pflooky commented Jul 27, 2025

Copy link
Copy Markdown
Contributor Author

Schema Diff Analysis

📋 Schema Changes Detected

Files compared:

  • Previous: odcs-json-schema-v3.0.2-strict.json
  • New: odcs-json-schema-v3.1.0.json

Diff:

--- /var/folders/jm/7s7fxpz93qv430b5fc1t0x880000gn/T/tmp.2mtCfbBJZZ	2025-07-27 19:28:31
+++ /var/folders/jm/7s7fxpz93qv430b5fc1t0x880000gn/T/tmp.Tn0DPlQBk4	2025-07-27 19:28:31
@@ -465,14 +465,12 @@
                 "additionalProperties": false,
                 "properties": {
                   "exclusiveMaximum": {
-                    "default": false,
-                    "description": "If set to true, all values are strictly less than the maximum value (values < maximum). Otherwise, less than or equal to the maximum value (values <= maximum).",
-                    "type": "boolean"
+                    "description": "All values must be strictly less than this value (values < exclusiveMaximum).",
+                    "type": "string"
                   },
                   "exclusiveMinimum": {
-                    "default": false,
-                    "description": "If set to true, all values are strictly greater than the minimum value (values > minimum). Otherwise, greater than or equal to the minimum value (values >= minimum).",
-                    "type": "boolean"
+                    "description": "All values must be strictly greater than this value (values > exclusiveMinimum).",
+                    "type": "string"
                   },
                   "format": {
                     "description": "Format of the date. Follows the format as prescribed by [JDK DateTimeFormatter](https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html). For example, format 'yyyy-MM-dd'.",
@@ -515,14 +513,12 @@
                 "additionalProperties": false,
                 "properties": {
                   "exclusiveMaximum": {
-                    "default": false,
-                    "description": "If set to true, all values are strictly less than the maximum value (values < maximum). Otherwise, less than or equal to the maximum value (values <= maximum).",
-                    "type": "boolean"
+                    "description": "All values must be strictly less than this value (values < exclusiveMaximum).",
+                    "type": "number"
                   },
                   "exclusiveMinimum": {
-                    "default": false,
-                    "description": "If set to true, all values are strictly greater than the minimum value (values > minimum). Otherwise, greater than or equal to the minimum value (values >= minimum).",
-                    "type": "boolean"
+                    "description": "All values must be strictly greater than this value (values > exclusiveMinimum).",
+                    "type": "number"
                   },
                   "format": {
                     "default": "i32",
@@ -578,14 +574,12 @@
                 "additionalProperties": false,
                 "properties": {
                   "exclusiveMaximum": {
-                    "default": false,
-                    "description": "If set to true, all values are strictly less than the maximum value (values < maximum). Otherwise, less than or equal to the maximum value (values <= maximum).",
-                    "type": "boolean"
+                    "description": "All values must be strictly less than this value (values < exclusiveMaximum).",
+                    "type": "number"
                   },
                   "exclusiveMinimum": {
-                    "default": false,
-                    "description": "If set to true, all values are strictly greater than the minimum value (values > minimum). Otherwise, greater than or equal to the minimum value (values >= minimum).",
-                    "type": "boolean"
+                    "description": "All values must be strictly greater than this value (values > exclusiveMinimum).",
+                    "type": "number"
                   },
                   "format": {
                     "default": "i32",

Summary:

  • Additions: 13 lines
  • Deletions: 19 lines

@jgperrin
jgperrin requested a review from simonharrer August 12, 2025 17:30
@jgperrin

Copy link
Copy Markdown
Contributor

Can someone merge?

@pflooky pflooky added this to the ODCS v3.1.0 milestone Aug 13, 2025
@pflooky pflooky linked an issue Aug 13, 2025 that may be closed by this pull request
@jgperrin
jgperrin merged commit bfa8b11 into bitol-io:dev Aug 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exclusiveMaximum and exclusiveMinimum should be a number, not a boolean

2 participants