Skip to content

Fix issues with new create wallet dialogue #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbddesign wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issues with new create wallet dialogue #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ee73f1
fix encrypt wallet wording
sbddesign Mar 25, 2026
778e6eb
gui: fix advanced options toggles
sbddesign Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/qt/createwalletdialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ CreateWalletDialog::CreateWalletDialog(QWidget* parent) :
connect(ui->blank_wallet_checkbox, &QCheckBox::toggled, [this](bool checked) {
// Disable the disable_privkeys_checkbox when blank_wallet_checkbox is checked
// as blank-ness only pertains to wallets with private keys.
ui->disable_privkeys_checkbox->setEnabled(!checked);
ui->disable_privkeys_checkbox->setEnabled(!checked && !ui->encrypt_wallet_checkbox->isChecked());
Copy link
Copy Markdown
Member

@luke-jr luke-jr Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the opposite fix is also needed?

I feel like this whole logic needs to be rewritten...

if (checked) {
ui->disable_privkeys_checkbox->setChecked(false);
}
Expand Down
2 changes: 1 addition & 1 deletion src/qt/forms/createwalletdialog.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
<item>
<widget class="QCheckBox" name="encrypt_wallet_checkbox">
<property name="toolTip">
<string>Encrypt the wallet. The wallet will be encrypted with a passphrase of your choice.</string>
<string>Encrypt the wallet's private key with a passphrase of your choice. Other wallet data such as transaction history will not be encrypted.</string>
</property>
<property name="text">
<string>Encrypt Wallet</string>
Expand Down
Loading