Skip to content

Adds non-mempool wallet balance to overview#911

Open
ajtowns wants to merge 1 commit intobitcoin-core:masterfrom
ajtowns:202511-wallet-unconf-bal-gui
Open

Adds non-mempool wallet balance to overview#911
ajtowns wants to merge 1 commit intobitcoin-core:masterfrom
ajtowns:202511-wallet-unconf-bal-gui

Conversation

@ajtowns
Copy link
Copy Markdown
Contributor

@ajtowns ajtowns commented Nov 19, 2025

The wallet can contain transactions that are not accepted into the node's mempool (eg due to containing a too large OP_RETURN output, due to too low a feerate, or due to too many unconfirmed ancestors). In the event you end up in this situation, it can appear as if funds have gone missing from your wallet due to the non-mempool balance not being reported. Correct this by reporting the non-mempool balance.

Depends on bitcoin/bitcoin#33671

@DrahtBot
Copy link
Copy Markdown
Contributor

DrahtBot commented Nov 19, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

No conflicts as of last run.

@ajtowns
Copy link
Copy Markdown
Contributor Author

ajtowns commented Nov 19, 2025

To test, start with -datacarriersize=10, and run

send '{"data": "4368616e63656c6c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73"}' null "unset" 1

from the console. "Non-mempool: " should appear in the Balances pane on the Overview window with the change from the transaction. Restarting with -datacarriersize=100000 should allow the tx to enter the mempool, and move the amount into the Available balance. (Presumably, do this on -regtest after generating 100 blocks; or perhaps signet after grabbing some funds from a faucet)

@ajtowns
Copy link
Copy Markdown
Contributor Author

ajtowns commented Nov 27, 2025

Screenshot:

non-mempool-gui

The negative sign for the non-memool stuff isn't really very clear, perhaps.

@ajtowns ajtowns force-pushed the 202511-wallet-unconf-bal-gui branch from bc85b4a to 026088b Compare April 23, 2026 02:32
@ajtowns ajtowns marked this pull request as ready for review April 23, 2026 02:33
@ajtowns
Copy link
Copy Markdown
Contributor Author

ajtowns commented Apr 23, 2026

Rebased after merge of parent PR, should be ready to review. Happy to close if some someone wants to take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants