fix(nvs): Fix typos in NVS configuration keys#1757
Open
psp0 wants to merge 1 commit into
Open
Conversation
Collaborator
|
NACK, this fails on upgrade. The key already exists for several versions, so people have config stored in NVS under the key with typo. It should have a migration handler in |
Author
Added migration handler in nvs_config_init_fallback. Please re-review. |
mutatrum
approved these changes
Jun 9, 2026
Author
|
Just force-pushed to remove an accidental merge commit. No code changes |
Collaborator
|
No need to update the branch if there are no conflicts, that will be taken care off on merge. |
WantClue
approved these changes
Jun 14, 2026
WantClue
left a comment
WantClue
left a comment
Collaborator
There was a problem hiding this comment.
good finding, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a simple typo in the nvs_config.c file