Refactor theme mechanism#1637
Open
mutatrum wants to merge 6 commits into
Open
Conversation
mutatrum
commented
Mar 28, 2026
| </div> | ||
|
|
||
| <div class="col-12 mt-4"> | ||
| <h5>Theme Color</h5> |
Collaborator
Author
There was a problem hiding this comment.
This file is extracted from theme-config.component.ts, only change is Theme Colors -> Theme Color
0xf0xx0
approved these changes
Apr 6, 2026
mutatrum
force-pushed
the
technicolor-dreamcoat
branch
from
36275f5 to
78d36f2
Compare
Collaborator
Author
|
Collaborator
|
two last things before merging, the buttons/checkboxes should also use contrast-color, and the hint indicators should be the fg color 
|
Collaborator
|
just resolved the minor conflict another quick test would be ideal |
Collaborator
Author
Makes more sense to do again after #1651. Keep open for now, to see what the conflicts will be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a lot of duplicate code in the theme system. Refactored it to only use a single RGB value, which makes it easy to do this while reducing line count: