Skip to content

fix check of invalid jwt.encode parameters from twitcher.oauth2.CustomTokenValidator - #153

Open
fmigneault wants to merge 1 commit into
masterfrom
fix-custom-token-generator
Open

fix check of invalid jwt.encode parameters from twitcher.oauth2.CustomTokenValidator#153
fmigneault wants to merge 1 commit into
masterfrom
fix-custom-token-generator

Conversation

@fmigneault

Copy link
Copy Markdown
Member

An incorrectly configured token validator (such as in the tests) would result in failure when invoking the token generation. They will be raised upon initialization to allow early catch of the problem.

FAILED tests/functional/test_oauth2_app.py::OAuth2AppTests::test_compute_with_header - TypeError: Issuer (iss) must be a string.
FAILED tests/functional/test_oauth2_app.py::OAuth2AppTests::test_compute_with_param - TypeError: Issuer (iss) must be a string.

Error seen during #152 CI runs.

@fmigneault
fmigneault requested a review from cehbrecht August 24, 2026 22:43
@fmigneault fmigneault self-assigned this Aug 24, 2026

@cehbrecht cehbrecht left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... when tests pass :)

@fmigneault

Copy link
Copy Markdown
Member Author

@cehbrecht
Do you want me to create a PR that combines everything? They are interlocking each other because of pkg_resource #149

I also see that CodeCov complains about a missing token.
I sent a request to accept in bird-house org. I do not have access to enable it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants