Gene to pheno disease association fixes#1686
Open
sierra-moxon wants to merge 4 commits intomasterfrom
Open
Conversation
…ne to disease or phenotypic feature association. add a work-around enumeration of predicates to use between gene and phenotype nodes as a work around for has_phenotype legacy plus associated_with vs. causes hierarchy challenges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while working on: #1680
I noticed a bloating hierarchy of mixins that didn't do a lot to reduce redundancy, per say, but did do a lot to obfuscate (in my opinion) the requirements to make an instance of the classes they informed on. So I am proposing removing that extra hierarchy, adding slots and constraints they grouped onto the classes they informed directly. Its a big set of diffs, but I think overall the model is easier to understand with this PR.